udp: consistently apply ufo or fragmentation
authorWillem de Bruijn <willemb@google.com>
Thu, 10 Aug 2017 16:29:19 +0000 (12:29 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 12 Aug 2017 22:09:26 +0000 (23:09 +0100)
commite651dd4cddde009d7582e7ee15b78848f16bb8fd
tree2b35b8c94a3e38762d463c994339d1a17004500d
parent6f2da15655cb7bcf1e08622faf0a79fd47961f60
udp: consistently apply ufo or fragmentation

When iteratively building a UDP datagram with MSG_MORE and that
datagram exceeds MTU, consistently choose UFO or fragmentation.

Once skb_is_gso, always apply ufo. Conversely, once a datagram is
split across multiple skbs, do not consider ufo.

Sendpage already maintains the first invariant, only add the second.
IPv6 does not have a sendpage implementation to modify.

A gso skb must have a partial checksum, do not follow sk_no_check_tx
in udp_send_skb.

Found by syzkaller.

Fixes: e89e9cf539a2 ("[IPv4/IPv6]: UFO Scatter-gather approach")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name udp-consistently-apply-ufo-or-fragmentation.patch
net/ipv4/ip_output.c
net/ipv4/udp.c
net/ipv6/ip6_output.c